Attention is currently required from: Felix Singer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75880?usp=email )
Change subject: soc/intel/skylake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
oh, yes. Did a quick check with GCC, bool is 1 byte. […]
Do we want to clean the array too? Like SataPortsEnable[0] = 1?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75880?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic40917689092e8d897a3ba92ac767cdb3b595eb3
Gerrit-Change-Number: 75880
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Wed, 21 Jun 2023 00:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment