Attention is currently required from: Hung-Te Lin, Raul Rangel, Jeff Daly, Philipp Hug, Mariusz Szafrański, Jonathan Zhang, Julius Werner, Angel Pons, Arthur Heymans, Andrey Petrov, Xi Chen, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Christian Walter, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Fred Reitberger, ron minnich, Felix Held, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64658 )
Change subject: [NOTFORMERGE] Add _kb postfix for resources taking KiB arguments
......................................................................
Patch Set 2: Verified+1
(6 comments)
File src/northbridge/intel/ironlake/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437):
https://review.coreboot.org/c/coreboot/+/64658/comment/d45cd612_0392014d
PS2, Line 57: mmio_resource_kb(dev, index++, legacy_hole_base_k, (0xc0000 / KiB) - legacy_hole_base_k);
line length of 97 exceeds 96 columns
File src/northbridge/intel/pineview/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437):
https://review.coreboot.org/c/coreboot/+/64658/comment/fd7ae19d_30b0dba9
PS2, Line 38: mmio_resource_kb(dev, index++, legacy_hole_base_k, (0xc0000 / KiB) - legacy_hole_base_k);
line length of 97 exceeds 96 columns
File src/northbridge/intel/sandybridge/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437):
https://review.coreboot.org/c/coreboot/+/64658/comment/623ee32f_adc8dfa6
PS2, Line 69: mmio_resource_kb(dev, index++, legacy_hole_base_k, (0xc0000 >> 10) - legacy_hole_base_k);
line length of 97 exceeds 96 columns
File src/soc/amd/cezanne/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437):
https://review.coreboot.org/c/coreboot/+/64658/comment/b99ced43_cf29e130
PS2, Line 167: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB);
line length of 97 exceeds 96 columns
File src/soc/amd/picasso/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437):
https://review.coreboot.org/c/coreboot/+/64658/comment/0fa19fa7_021b43bb
PS2, Line 165: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB);
line length of 97 exceeds 96 columns
File src/soc/amd/sabrina/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150437):
https://review.coreboot.org/c/coreboot/+/64658/comment/e7a4f244_f7eb44fc
PS2, Line 169: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB);
line length of 97 exceeds 96 columns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I329864d36137e9a99b5640f4f504c45a02060a40
Gerrit-Change-Number: 64658
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 02 Jun 2022 06:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment