Michael Walle has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43125 )
Change subject: libpayload: arm64: fix OUTPUT_ARCH() ......................................................................
libpayload: arm64: fix OUTPUT_ARCH()
There is no bfd "arm64". The correct bfdname is "aarch64". Fix it. With this change libpayload will build with the AArch64 GCC.
Change-Id: If7a6b14691107c5d4fc67c3cd3990ecc849d4af1 Signed-off-by: Michael Walle michael@walle.cc --- M payloads/libpayload/arch/arm64/libpayload.ldscript 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43125/1
diff --git a/payloads/libpayload/arch/arm64/libpayload.ldscript b/payloads/libpayload/arch/arm64/libpayload.ldscript index 8ebafce..f9fb771 100644 --- a/payloads/libpayload/arch/arm64/libpayload.ldscript +++ b/payloads/libpayload/arch/arm64/libpayload.ldscript @@ -28,7 +28,7 @@ */
OUTPUT_FORMAT("elf64-littleaarch64","elf64-littleaarch64", "elf64-littleaarch64") -OUTPUT_ARCH(arm64) +OUTPUT_ARCH(aarch64)
ENTRY(_entry)
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43125 )
Change subject: libpayload: arm64: fix OUTPUT_ARCH() ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43125/1/payloads/libpayload/arch/ar... File payloads/libpayload/arch/arm64/libpayload.ldscript:
https://review.coreboot.org/c/coreboot/+/43125/1/payloads/libpayload/arch/ar... PS1, Line 31: OUTPUT_ARCH(aarch64) I'm not sure why we even have this tbh. In our payload (where we have our own linker script) we don't supply this and the linker default just works fine.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43125 )
Change subject: libpayload: arm64: fix OUTPUT_ARCH() ......................................................................
libpayload: arm64: fix OUTPUT_ARCH()
There is no bfd "arm64". The correct bfdname is "aarch64". Fix it. With this change libpayload will build with the AArch64 GCC.
Change-Id: If7a6b14691107c5d4fc67c3cd3990ecc849d4af1 Signed-off-by: Michael Walle michael@walle.cc Reviewed-on: https://review.coreboot.org/c/coreboot/+/43125 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M payloads/libpayload/arch/arm64/libpayload.ldscript 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/payloads/libpayload/arch/arm64/libpayload.ldscript b/payloads/libpayload/arch/arm64/libpayload.ldscript index 8ebafce..f9fb771 100644 --- a/payloads/libpayload/arch/arm64/libpayload.ldscript +++ b/payloads/libpayload/arch/arm64/libpayload.ldscript @@ -28,7 +28,7 @@ */
OUTPUT_FORMAT("elf64-littleaarch64","elf64-littleaarch64", "elf64-littleaarch64") -OUTPUT_ARCH(arm64) +OUTPUT_ARCH(aarch64)
ENTRY(_entry)
-
Julius Werner (Code Review) -
Michael Walle (Code Review)
-
Patrick Georgi (Code Review)