Attention is currently required from: Raul Rangel.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56356 )
Change subject: lib/thread: Clean up initialization sequence
......................................................................
Patch Set 1:
(1 comment)
File src/lib/thread.c:
https://review.coreboot.org/c/coreboot/+/56356/comment/02fe00dd_a92cdca9
PS1, Line 261: t->can_yield = 1;
Why do we need to set this explicitly at this point? `prepare_thread()` always marks new threads as "can_yeild" (line 191).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56356
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f1d6afac3b0622612565b37c61fbd2cd2481552
Gerrit-Change-Number: 56356
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 16 Jul 2021 06:50:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment