Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60028 )
Change subject: payloads/U-Boot: Fix various build errors ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60028/comment/9206d01d_2acc866c PS2, Line 9: Target of U-Boot payload is inconsistent between Kconfig and : Makefile.inc. : : Perform full clone in order to get tags. : : Make Kconfig prompt for revision consistent with the revision : in Makefile.
Format it as a list?
Into which form of the list do you want me to format it?
File payloads/external/U-Boot/Kconfig:
https://review.coreboot.org/c/coreboot/+/60028/comment/530e873e_89f88f07 PS2, Line 12: UBOOT_STABLE
Could this be used instead of STABLE_COMMIT_ID in payloads/external/U-Boot/Makefile?
I managed to move the value of STABLE_COMMIT_ID into the Kconfig, but how can I assign a prompt with the value of a symbol?
File payloads/external/U-Boot/Makefile:
https://review.coreboot.org/c/coreboot/+/60028/comment/d6bd9646_2fcd0baf PS2, Line 28: git clone $(project_git_repo) $(project_dir)
This is fine but takes a little longer […]
The value of $(STABLE_COMMIT_ID) is a tag instead of a branch, and --branch can only be used on a branch.
-
Bill XIE (Code Review)