John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: UPSTREAM: mb/google/drallion: Remove fixed IccMax values ......................................................................
UPSTREAM: mb/google/drallion: Remove fixed IccMax values
Remove fixed IccMax values for U22 CPU. IccMax will be selected by CPU SKU in fill_vr_domain_config function.
BUG=b:148110226 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Change-Id: Ifcd31ad5b608ce599d4294a6522fdda022f8a177 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38503/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 75fd3ee..60e8ae7 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -90,7 +90,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(6), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 1030, .dc_loadline = 1030, @@ -105,7 +105,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(70), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 180, .dc_loadline = 180, @@ -120,7 +120,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310, @@ -135,7 +135,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310,
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: UPSTREAM: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38503/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38503/1/src/mainboard/google/dralli... PS1, Line 79: #| IccMax | 6A | 70A | 31A | 31A | add some logs here.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: UPSTREAM: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38503/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38503/1//COMMIT_MSG@7 PS1, Line 7: UPSTREAM Remove the "UPSTREAM" from subject line.
Hello Ivy Jian, EricR Lai, Edward O'Callaghan, Kane Chen, Frank Wu, Furquan Shaikh, Jamie Chen, Alan Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38503
to look at the new patch set (#2).
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
mb/google/drallion: Remove fixed IccMax values
Remove fixed IccMax values for U22 CPU. IccMax will be selected by CPU SKU in fill_vr_domain_config function.
BUG=b:148110226 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Change-Id: Ifcd31ad5b608ce599d4294a6522fdda022f8a177 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38503/2
Hello Ivy Jian, EricR Lai, Edward O'Callaghan, Kane Chen, Frank Wu, build bot (Jenkins), Furquan Shaikh, Jamie Chen, Alan Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38503
to look at the new patch set (#3).
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
mb/google/drallion: Remove fixed IccMax values
Remove fixed IccMax values for U22 CPU. IccMax will be selected by CPU SKU in fill_vr_domain_config function.
BUG=b:148110226 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Change-Id: Ifcd31ad5b608ce599d4294a6522fdda022f8a177 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38503/3
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38503/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38503/1//COMMIT_MSG@7 PS1, Line 7: UPSTREAM
Remove the "UPSTREAM" from subject line.
Done
https://review.coreboot.org/c/coreboot/+/38503/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38503/1/src/mainboard/google/dralli... PS1, Line 79: #| IccMax | 6A | 70A | 31A | 31A |
add some logs here.
Done
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 3: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38503/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38503/3//COMMIT_MSG@10 PS3, Line 10: IccMax will be selected by CPU SKU in : fill_vr_domain_config function. Fits on one line.
https://review.coreboot.org/c/coreboot/+/38503/3//COMMIT_MSG@16 PS3, Line 16: checked the log For what string?
Hello Ivy Jian, EricR Lai, Edward O'Callaghan, Kane Chen, Frank Wu, build bot (Jenkins), Furquan Shaikh, Jamie Chen, Alan Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38503
to look at the new patch set (#4).
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
mb/google/drallion: Remove fixed IccMax values
Remove fixed IccMax values for U22 CPU. IccMax will be selected by CPU SKU.
BUG=b:148110226 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked IccMax[1].
Change-Id: Ifcd31ad5b608ce599d4294a6522fdda022f8a177 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38503/4
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38503/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38503/3//COMMIT_MSG@10 PS3, Line 10: IccMax will be selected by CPU SKU in : fill_vr_domain_config function.
Fits on one line.
Done
https://review.coreboot.org/c/coreboot/+/38503/3//COMMIT_MSG@16 PS3, Line 16: checked the log
For what string?
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values ......................................................................
mb/google/drallion: Remove fixed IccMax values
Remove fixed IccMax values for U22 CPU. IccMax will be selected by CPU SKU.
BUG=b:148110226 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked IccMax[1].
Change-Id: Ifcd31ad5b608ce599d4294a6522fdda022f8a177 Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38503 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 75fd3ee..97860f4 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -65,7 +65,7 @@ register "PchHdaIDispCodecDisconnect" = "1" register "PchHdaAudioLinkHda" = "1"
- # VR Settings Configuration for 4 Domains + # VR Settings Configuration for 2/4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | #+----------------+-------+-------+-------+-------+ @@ -76,7 +76,7 @@ #| Psi4Enable | 1 | 1 | 1 | 1 | #| ImonSlope | 0 | 0 | 0 | 0 | #| ImonOffset | 0 | 0 | 0 | 0 | - #| IccMax | 6A | 70A | 31A | 31A | + #| IccMax | 6A | 35/70A| 31A | 31A | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | #| AcLoadline | 10.3 | 1.8 | 3.1 | 3.1 | #| DcLoadline | 10.3 | 1.8 | 3.1 | 3.1 | @@ -90,7 +90,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(6), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 1030, .dc_loadline = 1030, @@ -105,7 +105,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(70), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 180, .dc_loadline = 180, @@ -120,7 +120,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310, @@ -135,7 +135,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310,
-
Edward O'Callaghan (Code Review) -
EricR Lai (Code Review)
-
Jamie Chen (Code Review)
-
John Su (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)