Attention is currently required from: Nick Vaccaro, Subrata Banik.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
Change subject: mb/google/hatch: Add FP enable for Dratini ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/hatch/variants/dratini/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83745/comment/c00fc77b_3dc1fbf7?usp... : PS4, Line 29: }
do we need a default case for passing code static analyser check ? […]
The behavior change is desired and yes, it's because not all SKUs have a fingerprint sensor. Some devices were manufactured with reused MLBs from devices that had fingerprint, and the FPMCU was populated. Because of this, and because the AP FW indiscriminately enables power to the FPMCU, the FPMCU is present on the i2c bus and causes boid to errantly report FP issues and crashes.
Happy to add a default case variant.c. WDYT?
-
Jon Murphy (Code Review)