Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41815 )
Change subject: console: Update for vboot before bootblock
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/Makefile.inc
File src/console/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/Makefile.inc@16
PS6, Line 16: verstage-y += console.c
These are excluded because you want to be full message oriented? And not preform a svc call per byte? Can't we hook into console_tx_flush() to perform the full message write?
commit description isn't entirely clear why these need to be excluded. On first pass, it seems we can hook into the existing console drivers with a message oriented one w/o making any changes. Was this path pursued?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc9fb0810e0816fe0a68e52287eda6145043a619
Gerrit-Change-Number: 41815
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 16:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment