Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel.
Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84918?usp=email )
Change subject: soc/amd/common/acpi: Add SPI flash controller
......................................................................
Patch Set 1:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84918/comment/e3577a8e_ccee6384?usp... :
PS1, Line 10:
Did you write it from scratch? Please document the sources you used.
Actually, no. I'm just upstreaming internal changes..
File src/soc/amd/common/acpi/spi.asl:
https://review.coreboot.org/c/coreboot/+/84918/comment/0f38e2b4_d45d941d?usp... :
PS1, Line 11: Device(SPI1) { // SPI controller
: Name(_HID, "AMDI0062")
Aren’t we using also tabs for indentation for ASL files?
Done
https://review.coreboot.org/c/coreboot/+/84918/comment/7db4bbf3_fd8a7c55?usp... :
PS1, Line 72: } // End Device SPI1
lack of final newline is causing the linter check to fail here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84918?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f2c1e3351671ad47fbe5c890e4f99d2e19dbfbf
Gerrit-Change-Number: 84918
Gerrit-PatchSet: 1
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 25 Nov 2024 18:40:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org