Attention is currently required from: Andrey Petrov.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69499 )
Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob ......................................................................
driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
Use the new fsp_hob_iterator_get_next_guid_extension function in fsp_display_fvi_version_hob instead of iterating through the HOB list in this function.
TEST=Not tested on hardware, since no AMD SoC uses this functionality
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 21 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/69499/1
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 2ded33699..8f51159 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -317,22 +317,15 @@
void fsp_display_fvi_version_hob(void) { - const uint8_t *hob_uuid; - const struct hob_header *hob = fsp_get_hob_list(); + const void *hob_uuid; + size_t hob_size;
- if (!hob) - return; + hob_uuid = fsp_find_extension_hob_by_guid(uuid_fv_info, &hob_size);
printk(BIOS_DEBUG, "Display FSP Version Info HOB\n"); - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_GUID_EXTENSION) - continue;
- hob_uuid = hob_header_to_struct(hob); - - if (fsp_guid_compare(hob_uuid, uuid_fv_info)) { - display_fsp_version_info_hob(hob); - } + if (hob_uuid != NULL) { + display_fsp_version_info_hob(hob_uuid); } }