Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34410 )
Change subject: soc/intel: Change file to __SIMPLE_DEVICE__ ......................................................................
soc/intel: Change file to __SIMPLE_DEVICE__
All the PCI accesses in the file are now accessed without SA_DEV_ROOT expanding to function call.
Change-Id: I30d331e9c18a486ea971e8397a6e20a0f82d5f84 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/common/block/systemagent/systemagent_early.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/34410/1
diff --git a/src/soc/intel/common/block/systemagent/systemagent_early.c b/src/soc/intel/common/block/systemagent/systemagent_early.c index c12c64a..8c89c07 100644 --- a/src/soc/intel/common/block/systemagent/systemagent_early.c +++ b/src/soc/intel/common/block/systemagent/systemagent_early.c @@ -13,6 +13,8 @@ * GNU General Public License for more details. */
+#define __SIMPLE_DEVICE__ + #include <device/mmio.h> #include <device/pci_ops.h> #include <device/device.h> @@ -24,7 +26,6 @@
#include "systemagent_def.h"
-#if ENV_BOOTBLOCK void bootblock_systemagent_early_init(void) { uint32_t reg; @@ -63,7 +64,6 @@ */ pci_write_config32(SA_DEV_ROOT, TSEG, 0); } -#endif
void sa_set_pci_bar(const struct sa_mmio_descriptor *fixed_set_resources, size_t count)
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34410 )
Change subject: soc/intel: Change file to __SIMPLE_DEVICE__ ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34410 )
Change subject: soc/intel: Change file to __SIMPLE_DEVICE__ ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34410 )
Change subject: soc/intel: Change file to __SIMPLE_DEVICE__ ......................................................................
soc/intel: Change file to __SIMPLE_DEVICE__
All the PCI accesses in the file are now accessed without SA_DEV_ROOT expanding to function call.
Change-Id: I30d331e9c18a486ea971e8397a6e20a0f82d5f84 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34410 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/systemagent/systemagent_early.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/common/block/systemagent/systemagent_early.c b/src/soc/intel/common/block/systemagent/systemagent_early.c index c12c64a..8c89c07 100644 --- a/src/soc/intel/common/block/systemagent/systemagent_early.c +++ b/src/soc/intel/common/block/systemagent/systemagent_early.c @@ -13,6 +13,8 @@ * GNU General Public License for more details. */
+#define __SIMPLE_DEVICE__ + #include <device/mmio.h> #include <device/pci_ops.h> #include <device/device.h> @@ -24,7 +26,6 @@
#include "systemagent_def.h"
-#if ENV_BOOTBLOCK void bootblock_systemagent_early_init(void) { uint32_t reg; @@ -63,7 +64,6 @@ */ pci_write_config32(SA_DEV_ROOT, TSEG, 0); } -#endif
void sa_set_pci_bar(const struct sa_mmio_descriptor *fixed_set_resources, size_t count)
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)
-
Martin Roth (Code Review)