Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33770 )
Change subject: soc/amd/picasso: Update southbridge ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33770/4/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/33770/4/src/soc/amd/picasso/include... PS4, Line 173: BIT(2)
Either this register is the same as last time, and it's actually a disable register or it's been upd […]
I think the resolution of https://review.coreboot.org/c/coreboot/+/33768/4//COMMIT_MSG will flow through to this patch. I'll plan to update/correct/comment there.
-
Marshall Dawson (Code Review)