Attention is currently required from: Alper Nebi Yasak.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80370?usp=email )
Change subject: mainboard/qemu-aarch64: Enable QEMU fw_cfg driver ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80370/comment/8d9c3b9e_5e83da9c : PS1, Line 12: [1] https://gitlab.com/qemu-project/qemu/-/blob/v8.2.1/hw/arm/virt.c#L150 Can you use an archive.org link instead of directly linking?
File src/mainboard/emulation/qemu-aarch64/include/mainboard/addressmap.h:
https://review.coreboot.org/c/coreboot/+/80370/comment/79867b22_e7e5de57 : PS1, Line 25: #define VIRT_FW_CFG_BASE 0x09020000 Any reason this is needed in addition to the Kconfig option? It seems like you could use one or the other. By having it defined in two places, you run the risk of them not being the same.
At the very least, you could use CONFIG_QEMU_FW_CFG_BASE_ADDRESS here instead of a fixed value.