Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68184 )
Change subject: soc/amd/common/psp_verstage: Pass SRAM buffer to Crypto Engine
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/soc/amd/common/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/68184/comment/631f1fa8_c81fc36d
PS10, Line 98: CONFIG_VBOOT_HASH_BLOCK_SIZE
My testing indicated it should not. […]
Hrmm: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
I guess the stack is at the very end: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
so if it does overflow we will panic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9bc9e786f302e7938969c8093d5405b5a85b711
Gerrit-Change-Number: 68184
Gerrit-PatchSet: 10
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 26 Oct 2022 17:18:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment