Attention is currently required from: Boris Mittelberg, Caveh Jalali, Kapil Porwal, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85449?usp=email )
Change subject: ec/google/chromeec: Add indexed IO support
......................................................................
Patch Set 2:
(2 comments)
This change is ready for review.
File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/85449/comment/73964953_4da0e0a8?usp... :
PS1, Line 63: EC_GOOGLE_CHROMEEC_INDEXED_IO
`EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO`
Acknowledged
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/85449/comment/17e37b13_6d904de5?usp... :
PS1, Line 59: u8 byte;
: outb(offset, port);
: port = port + 1;
: byte = inb(port);
: return byte;
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85449?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0
Gerrit-Change-Number: 85449
Gerrit-PatchSet: 2
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 18:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com