[S] Change in coreboot[master]: drivers/intel/ish: Hook get ISH version into `.final`

[Arthur Heymans (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Paul Menzel, Sridhar Siricilla.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )

Change subject: drivers/intel/ish: Hook get ISH version into `.final`
......................................................................

Patch Set 17:

(1 comment)

File src/drivers/intel/ish/ish.c:

https://review.coreboot.org/c/coreboot/+/74209/comment/79aee8a9_9b984cfc 
PS17, Line 53: struct cse_fw_partition_info *version = cbmem_find(CBMEM_ID_CSE_PARTITION_VERSION);
             : 	if (version == NULL)
             : 		return;
             : 
             : 	printk(BIOS_DEBUG, "ISH version: %d.%d.%d.%d\n",
             : 		version->ish_partition_info.cur_ish_fw_version.major,
             : 		version->ish_partition_info.cur_ish_fw_version.minor,
             : 		version->ish_partition_info.cur_ish_fw_version.hotfix,
             : 		version->ish_partition_info.cur_ish_fw_version.build);
> I'm confused. Is finding the ish_partition_info ever not done in ramstage? Why do you need to save in cbmem and not in a local data structure (static global variable) with functions to report it?

NVM I think I missed the assumption that cbmem can be recovered on warm reset.