Attention is currently required from: Martin Roth, Paul Menzel, Angel Pons, Moritz Fischer. Moritz Fischer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50625 )
Change subject: mainboard/pine64/rockpro64: Add initial ROCKPro64 support ......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50625/comment/792c4cf9_70f31833 PS6, Line 21: For UART pins 6, 8 and 10 on the PI-2 connector can be used.
It would be nice to write down the pin mapping. For example: […]
Done
https://review.coreboot.org/c/coreboot/+/50625/comment/da1b7ee0_e85f9ff7 PS6, Line 24: it's
nit: possessive `its` doesn't have an apostrophe
Done
https://review.coreboot.org/c/coreboot/+/50625/comment/c550c882_1e9b72e5 PS6, Line 30:
nit: one space is enough
Done
File src/mainboard/pine64/rockpro64/board_info.txt:
https://review.coreboot.org/c/coreboot/+/50625/comment/2d75c4ff_38edffa6 PS6, Line 3: eval
I'd say the ROCKPro64 is a single-board computer, so this could be changed to `sbc`
Done
-
Moritz Fischer (Code Review)