Attention is currently required from: Jonathan Zhang, Angel Pons, Arthur Heymans, Shuming Chu (Shuming), TangYiwei.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 )
Change subject: cpu/x86/topology: Add code to fill in topology on struct path ......................................................................
Patch Set 6:
(4 comments)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/35f08c0d_4bb20de0 PS6, Line 198: dev->path.apic.apic_id = lapicid(); Already assumes dev->path.type as APIC here.
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/f74c3626_2a8d02be PS6, Line 67: if (cpu->path.type != DEVICE_PATH_APIC) Should be done earlier.
https://review.coreboot.org/c/coreboot/+/69222/comment/4dfdb925_8d1d9875 PS6, Line 84: cpu->path.apic.thread_id = apicid & ((1 << thread_bits) - 1); Bring set_cpu_topology() into this file?
File src/include/cpu/x86/topology.h:
https://review.coreboot.org/c/coreboot/+/69222/comment/6a9db898_ecca05da PS6, Line 9: */ Tests for .thread_id will fail after cb:69225 if no topology is filled in.