Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83649?usp=email )
Change subject: soc/mediatek/mt8196/memlayout: Fix the location of BOOTBLOCK comment ......................................................................
soc/mediatek/mt8196/memlayout: Fix the location of BOOTBLOCK comment
The comment for the BOOTBLOCK region should be written right above the BOOTBLOCK declaration.
BUG=b:317009620 TEST=none BRANCH=none
Change-Id: I7afdf74844a9d97169b4e4a23c3c9c6060e886d9 Signed-off-by: Yu-Ping Wu yupingso@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/83649 Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Yidi Lin yidilin@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8196/include/soc/memlayout.ld 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/mediatek/mt8196/include/soc/memlayout.ld b/src/soc/mediatek/mt8196/include/soc/memlayout.ld index e0975c7..664e55b 100644 --- a/src/soc/mediatek/mt8196/include/soc/memlayout.ld +++ b/src/soc/mediatek/mt8196/include/soc/memlayout.ld @@ -40,8 +40,8 @@ * aarch64-cros-linux-gnu-objdump -x dram.elf | grep memsz */ DRAM_INIT_CODE(0x02000000, 600K) - /* 4K reserved for BOOTROM until BOOTBLOCK is started */ #else + /* The beginning 4K of SRAM_L2C is reserved for BOOTROM until BOOTBLOCK is started. */ BOOTBLOCK(0x02001000, 60K) #endif OVERLAP_DECOMPRESSOR_VERSTAGE_ROMSTAGE(0x02096000, 272K)