Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has posted comments on this change by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
Change subject: gma pipe_setup: Update for TGL & ADL ......................................................................
Patch Set 36:
(1 comment)
Patchset:
PS36:
Maaaaaybe I can use CB:83979 to test this patch train?
Sure, I think ADL-N is really just ADL-P without P-cores.
I also have some small ADL-P board (w/o coreboot) that I wanted to test gfx_test on. But didn't get that far yet. TGL seems pretty much working right now with my latest pushes but there are some regressions in the big CB:67801 sink. I'm currently trying to untangle this in my spare time right now (again; originally it was a small patch as the commit message suggests), but that branch is not ready for ADL testing. Let me know if I should push that anyway.
I guess the ADL work is pretty much ready for the early sign-off live over eDP. But the general boot-time graphics support looks more like it was left in a PoC state, with the original, more comprehensive TGL work regressed. (That's all assuming that we picked the right patches from the relation chain.)
-
Nico Huber (Code Review)