Attention is currently required from: Paul Menzel, Reka Norman, Sumeet R Pawnikar, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75681?usp=email )
Change subject: mb/google/dedede/var/dibbi: Update power limits
......................................................................
Patch Set 11:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75681/comment/aa6f3000_708adedc :
PS10, Line 9: limit
limit*s*?
Done
https://review.coreboot.org/c/coreboot/+/75681/comment/a4e9df7c_4bb620fa :
PS10, Line 10:
What were the default(?) limits before your change?
Before my change, power limits are set in devicetree.
File src/mainboard/google/dedede/variants/dibbi/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75681/comment/76dc51bf_f6785522 :
PS10, Line 6: .
Not needed.
Done
https://review.coreboot.org/c/coreboot/+/75681/comment/8047eb4a_f57a529d :
PS10, Line 14: b/w
I’d write between, as there are non-native readers too.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75681?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
Gerrit-Change-Number: 75681
Gerrit-PatchSet: 11
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chia-Ling Hou
chia-ling.hou@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 05:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment