Change in coreboot[master]: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA control...
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller"
This reverts commit 65605276a4cd08fd2e38f87cd80e3362265f9091.
This patch shouldn't have been merged yet, since the issues on the FSP side aren't sorted out yet, so the FSP-side changes haven't landed yet. This byte will be used for an audio-related setting instead to have the audio settings grouped together.
Change-Id: If79900f3a92fd949d7653001e1ca2faac7061e3c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/vendorcode/amd/fsp/picasso/FspmUpd.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/44678/1
diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h index 63cc4ae..c1766e8 100644 --- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h +++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h @@ -58,7 +58,7 @@ /** Offset 0x00C8**/ uint32_t tseg_size; /** Offset 0x00CC**/ uint8_t pspp_policy; /** Offset 0x00CD**/ uint8_t audio_soundwire; - /** Offset 0x00CE**/ uint8_t sata_disable; + /** Offset 0x00CE**/ uint8_t unused8; /** Offset 0x00CF**/ uint8_t unused9; /** Offset 0x00D0**/ uint32_t bert_size; /** Offset 0x00D4**/ uint8_t UnusedUpdSpace0;
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Patch Set 1: Code-Review+2
I see you are reusing the upd field offset.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I see you are reusing the upd field offset.
that was used in the sata change, but apart from the coreboot upd field that shouldn't have been submitted, but got submitted, this wasn't used anywhere. the intention to use this byte for the hda enablement is tohave the audio settings grouped together
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44678
to look at the new patch set (#2).
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller"
This reverts commit 65605276a4cd08fd2e38f87cd80e3362265f9091.
This patch shouldn't have been merged yet, since the issues on the FSP side aren't sorted out yet, so the FSP-side changes haven't landed yet. This byte will be used for an audio-related setting instead to have the audio settings grouped together.
BRANCH=zork
Change-Id: If79900f3a92fd949d7653001e1ca2faac7061e3c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/vendorcode/amd/fsp/picasso/FspmUpd.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/44678/2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44678 )
Change subject: Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller" ......................................................................
Revert "vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller"
This reverts commit 65605276a4cd08fd2e38f87cd80e3362265f9091.
This patch shouldn't have been merged yet, since the issues on the FSP side aren't sorted out yet, so the FSP-side changes haven't landed yet. This byte will be used for an audio-related setting instead to have the audio settings grouped together.
BRANCH=zork
Change-Id: If79900f3a92fd949d7653001e1ca2faac7061e3c Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/44678 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/fsp/picasso/FspmUpd.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h index 63cc4ae..c1766e8 100644 --- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h +++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h @@ -58,7 +58,7 @@ /** Offset 0x00C8**/ uint32_t tseg_size; /** Offset 0x00CC**/ uint8_t pspp_policy; /** Offset 0x00CD**/ uint8_t audio_soundwire; - /** Offset 0x00CE**/ uint8_t sata_disable; + /** Offset 0x00CE**/ uint8_t unused8; /** Offset 0x00CF**/ uint8_t unused9; /** Offset 0x00D0**/ uint32_t bert_size; /** Offset 0x00D4**/ uint8_t UnusedUpdSpace0;
-
Aaron Durbin (Code Review) -
Felix Held (Code Review)
-
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)