Michele Guerini Rocco has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48937 )
Change subject: util/xcompile: fix XGCCPATH handling ......................................................................
util/xcompile: fix XGCCPATH handling
This patch fixes the build with an external (coreboot) toolchain. When the toolchain is not under util/crossgcc/xgcc, setting XGCCPATH to /path/to/toolchain results in the error:
toolchain.inc:169: The coreboot toolchain version of iasl '<date>' was not found
The reason is that the xcompile script incorrectly assumes XGCCPATH to have a trailing slash.
Change-Id: Ifcc4bd2b081fa3603420dc0a8cab3b47967ebc65 Signed-off-by: rnhmjoj rnhmjoj@inventati.org --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/48937/1
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index c237423..9fdda03 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -51,7 +51,7 @@
if [ "$("${XGCCPATH}/iasl" 2>/dev/null | grep -c ACPI)" -gt 0 ]; then - IASL=${XGCCPATH}iasl + IASL=${XGCCPATH}/iasl elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then IASL=iasl fi
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48937 )
Change subject: util/xcompile: fix XGCCPATH handling ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48937
to look at the new patch set (#2).
Change subject: util/xcompile: fix XGCCPATH handling ......................................................................
util/xcompile: fix XGCCPATH handling
This patch fixes the build with an external (coreboot) toolchain. When the toolchain is not under util/crossgcc/xgcc, setting XGCCPATH to /path/to/toolchain results in the error:
toolchain.inc:169: The coreboot toolchain version of iasl '<date>' was not found
The reason is that the xcompile script incorrectly assumes XGCCPATH to have a trailing slash.
Change-Id: Ifcc4bd2b081fa3603420dc0a8cab3b47967ebc65 Signed-off-by: Michele Guerini Rocco rnhmjoj@inventati.org --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/48937/2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48937 )
Change subject: util/xcompile: fix XGCCPATH handling ......................................................................
util/xcompile: fix XGCCPATH handling
This patch fixes the build with an external (coreboot) toolchain. When the toolchain is not under util/crossgcc/xgcc, setting XGCCPATH to /path/to/toolchain results in the error:
toolchain.inc:169: The coreboot toolchain version of iasl '<date>' was not found
The reason is that the xcompile script incorrectly assumes XGCCPATH to have a trailing slash.
Change-Id: Ifcc4bd2b081fa3603420dc0a8cab3b47967ebc65 Signed-off-by: Michele Guerini Rocco rnhmjoj@inventati.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/48937 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index c237423..9fdda03 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -51,7 +51,7 @@
if [ "$("${XGCCPATH}/iasl" 2>/dev/null | grep -c ACPI)" -gt 0 ]; then - IASL=${XGCCPATH}iasl + IASL=${XGCCPATH}/iasl elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then IASL=iasl fi
-
Hung-Te Lin (Code Review) -
Michele Guerini Rocco (Code Review)
-
Nico Huber (Code Review)