Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80735?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: lib: Declare heap in assembly ......................................................................
lib: Declare heap in assembly
Some linkers like LLD don't set up the NOBITS flag on the .heap section when just declaring that region in the linker script. This would have the program loader initialize the heap, which is not desirable for performance reasons. Also if the cbfs file would not be compressed it would be huge as the default heap is 1M.
Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/lib/Makefile.mk A src/lib/heap.S M src/lib/program.ld 3 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/80735/3