Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38088 )
Change subject: mb/hp/revolve_810_g1: Drop default DRAM_RESET_GATE_GPIO ......................................................................
mb/hp/revolve_810_g1: Drop default DRAM_RESET_GATE_GPIO
When this board was added, S3 resume was tested and working, so it must be good enough.
Change-Id: Ie095868ea2de7846b995271baf8155e57b495e40 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/hp/revolve_810_g1/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/38088/1
diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index f8a5f3f..3bcfc63 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -38,10 +38,6 @@ string default "8086,0166"
-config DRAM_RESET_GATE_GPIO # FIXME: check this - int - default 60 - config MAX_CPUS int default 8
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38088 )
Change subject: mb/hp/revolve_810_g1: Drop default DRAM_RESET_GATE_GPIO ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38088 )
Change subject: mb/hp/revolve_810_g1: Drop default DRAM_RESET_GATE_GPIO ......................................................................
mb/hp/revolve_810_g1: Drop default DRAM_RESET_GATE_GPIO
When this board was added, S3 resume was tested and working, so it must be good enough.
Change-Id: Ie095868ea2de7846b995271baf8155e57b495e40 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38088 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/hp/revolve_810_g1/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index f8a5f3f..3bcfc63 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -38,10 +38,6 @@ string default "8086,0166"
-config DRAM_RESET_GATE_GPIO # FIXME: check this - int - default 60 - config MAX_CPUS int default 8