Attention is currently required from: Eric Lai, Jakub Czapiga, Kangheui Won, Sukumar Ghorai, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76835?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex: enable d3hot for storage devices ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76835/comment/2dd19361_24619d65 : PS3, Line 9: is needed to set needs to be set
https://review.coreboot.org/c/coreboot/+/76835/comment/1d6fa971_c7e9d8a1 : PS3, Line 13: bypass bypasses
https://review.coreboot.org/c/coreboot/+/76835/comment/580b8f7c_064cb094 : PS3, Line 13: This feature also bypass the low LTR requirenet from SSD that blocking S0i2.2 LTR soc requirement. Please reflow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/76835/comment/7ff09c49_0542946d : PS3, Line 13: requirenet requirement
https://review.coreboot.org/c/coreboot/+/76835/comment/8fb30c68_b8e88ac5 : PS3, Line 15: Name (_DSD, Package () { : ToUUID("5025030F-842F-4AB4-A561-99A5189762D0"), : Package () { : Package (2) {"StorageD3Enable", 1}, : // 1 - Enable; 0 - Disable : } : } : ) Please use either tabs or spaces for indentation.