Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: shkim, Henry Sun, Evan Green, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )

Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................

Patch Set 11:

(6 comments)

File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:

https://review.coreboot.org/c/coreboot/+/60190/comment/72dd153e_1f4c8354 
PS11, Line 26: if (display_init_required())
`if (display_init_required() || !igd_dev)`

https://review.coreboot.org/c/coreboot/+/60190/comment/3dcd6214_e99ff8e6 
PS11, Line 29: pci_read_config32(igd_dev, PCI_BASE_ADDRESS_0) & 0xfffffff0;
`mmio32 = find_resource(igd_dev, PCI_BASE_ADDRESS_0)->base;`

https://review.coreboot.org/c/coreboot/+/60190/comment/aa5fde6f_ccac3c9b 
PS11, Line 32: addr32 = mmio32 + PCH_PP_CONTROL;
             : 	data32 = read32((void *) addr32);
             : 	data32 = data32 | 0x1;
             : 	write32((void *)addr32, data32);
             : 
This can be simplified to:

```
setbits32((void *)(mmio32 + PCH_PP_CONTROL), 0x1);
```

https://review.coreboot.org/c/coreboot/+/60190/comment/e15d1f19_87199c96 
PS11, Line 40: addr32 = mmio32 + PCH_GPIOB;
             : 	data32 = read32((void *) addr32);
             : 	data32 |= GPIO_CLOCK_VAL_OUT;
             : 	data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK;
             : 	write32((void *)addr32, data32);
Similarly

```
data32 = GPIO_CLOCK_VAL_MASK | GPIO_CLOCK_VAL_OUT | GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT;
setbits32((void *)(mmio32 + PCH_GPIOB), data32);
```

https://review.coreboot.org/c/coreboot/+/60190/comment/8e4c7923_7ca8ba24 
PS11, Line 49: addr32 = mmio32 + PCH_GPIOB;
             : 	data32 = read32((void *) addr32);
             : 	data32 &= ~GPIO_CLOCK_VAL_OUT;
             : 	data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK;
             : 	write32((void *)addr32, data32);
```
clrsetbits32((void *)(mmio32 + PCH_GPIOB),
              GPIO_CLOCK_VAL_OUT,
              GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK);
```

https://review.coreboot.org/c/coreboot/+/60190/comment/cc334f68_ec687c1e 
PS11, Line 58: addr32 = mmio32 + PCH_GPIOB;
             : 	data32 = read32((void *) addr32);
             : 	data32 |= GPIO_CLOCK_VAL_OUT;
             : 	data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK;
             : 	write32((void *)addr32, data32);
```
data32 = GPIO_CLOCK_VAL_MASK | GPIO_CLOCK_VAL_OUT | GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT;
setbits32((void *)(mmio32 + PCH_GPIOB), data32);
```