Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45542 )
Change subject: mb/Kconfig: add option for selecting the default state of s0ix ......................................................................
Patch Set 1:
Patch Set 1:
I'm not sure if s0ix works regardless of hardware support. If s0ix doesn't require the mainboard to wire something in a certain way, then we can have a prompt in Kconfig to choose whether to enable it. I'd also add a Kconfig so that mainboards can easily enable s0ix by default, but without force-enabling s0ix as a plain `select` would. If hardware support is required, then one would have a Kconfig symbol to indicate a mainboard supports s0ix, and another one (that could just default to y) to let the user choose whether to enable it (I assume that non-s0ix would always work)
Does anyone happen to know if s0ix depends on whether mainboard designs implement something?
I am not aware of any board design dependency. There is that SLP_S0 pin that *can* or *should* be connected to the VR or EC to give them the ability to go to lighter modes, too. It is not mandatory, AFAICT.