Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: trogdor: SoC makefile BLOB support
......................................................................
Patch Set 87:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG@7
PS87, Line 7: trogdor: SoC makefile BLOB support
Please make it a statement by using a verb (in imperative mood).
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG@7
PS87, Line 7: BLOB
blob
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG@8
PS87, Line 8:
Please elaborate what blobs are added, and what they are.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35508
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1
Gerrit-Change-Number: 35508
Gerrit-PatchSet: 87
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 10:42:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment