Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to review the following change.
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc 2 files changed, 28 insertions(+), 112 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/1
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index b29bd99..1683306 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -194,12 +194,20 @@ string "GEC firmware path and filename" depends on STONEYRIDGE_GEC_FWM
-config AMD_PUBKEY_FILE - string "AMD public Key" +config AMDFW_CONFIG_FILE + string + string "AMD PSP Firmware config file" default "" if !USE_AMD_BLOBS - default "3rdparty/amd_blobs/stoneyridge/PSP/CZ/AmdPubKeyCZ.bin" if AMD_APU_MERLINFALCON - default "3rdparty/amd_blobs/stoneyridge/PSP/ST/AmdPubKeyST.bin" if AMD_APU_PRAIRIEFALCON - default "3rdparty/amd_blobs/stoneyridge/PSP/ST/AmdPubKeyST.bin" if AMD_APU_STONEYRIDGE + default "3rdparty/amd_blobs/stoneyridge/PSP/CZ/fw.cfg" if AMD_APU_MERLINFALCON + default "3rdparty/amd_blobs/stoneyridge/PSP/ST/fw.cfg" if AMD_APU_PRAIRIEFALCON + default "3rdparty/amd_blobs/stoneyridge/PSP/ST/fw.cfg" if AMD_APU_STONEYRIDGE + +#config AMD_PUBKEY_FILE +# string "AMD public Key" +# default "" if !USE_AMD_BLOBS +# default "3rdparty/amd_blobs/stoneyridge/PSP/CZ/AmdPubKeyCZ.bin" if AMD_APU_MERLINFALCON +# default "3rdparty/amd_blobs/stoneyridge/PSP/ST/AmdPubKeyST.bin" if AMD_APU_PRAIRIEFALCON +# default "3rdparty/amd_blobs/stoneyridge/PSP/ST/AmdPubKeyST.bin" if AMD_APU_STONEYRIDGE
config STONEYRIDGE_SATA_MODE int "SATA Mode" diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.inc index 289f54b..07f0456 100644 --- a/src/soc/amd/stoneyridge/Makefile.inc +++ b/src/soc/amd/stoneyridge/Makefile.inc @@ -101,7 +101,9 @@ 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1)
### 0 -FIRMWARE_LOCATE=$(dir $(call strip_quotes, $(CONFIG_AMD_PUBKEY_FILE))) + +FIRMWARE_LOCATE=$(dir $(call strip_quotes, $(CONFIG_AMDFW_CONFIG_FILE))) + ifneq ($(FIRMWARE_LOCATE),)
ifeq ($(CONFIG_AMD_APU_STONEYRIDGE),y) @@ -119,20 +121,11 @@ endif # CONFIG_AMD_APU_MERLINFALCON endif # CONFIG_AMD_APU_STONEYRIDGE
-###5 -PUBSIGNEDKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/RtmPubSigned$(FIRMWARE_TYPE).key +add_opt_prefix=$(if $(call strip_quotes, $(1)), $(2) $(call strip_quotes, $(1)), )
-###1 -PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader_prod_$(FIRMWARE_TYPE).sbin +OPT_STONEYRIDGE_XHCI_FWM_FILE=$(call add_opt_prefix, $(CONFIG_STONEYRIDGE_XHCI_FWM_FILE), --xhci) +OPT_STONEYRIDGE_GEC_FWM_FILE=$(call add_opt_prefix, $(CONFIG_STONEYRIDGE_GEC_FWM_FILE), --gec)
-###3 -PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecoveryBootLoader_prod_$(FIRMWARE_TYPE).sbin - -###4 -PSPNVRAM_FILE=$(top)/$(FIRMWARE_LOCATE)/PspNvram$(FIRMWARE_TYPE).bin - -###8 - Check for SMU firmware named either *.sbin or *.csbin. Both "signed" and -### "compressed signed" are used by generations supported by this file. SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware_$(FIRMWARE_TYPE).csbin SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware_$(FIRMWARE_TYPE)_FN.csbin ifeq ("$(wildcard $(SMUFWM_FILE))","") @@ -140,113 +133,28 @@ SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE)_FN.sbin endif
-###95 -SMUSCS_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuScs$(FIRMWARE_TYPE).bin - -###9 -PSPSECUREDEBUG_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureDebug$(FIRMWARE_TYPE).Key - -ifeq ($(CONFIG_USE_PSPSECUREOS),y) -###2 -PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_$(FIRMWARE_TYPE).csbin - -###12 -PSPTRUSTLETS_FILE=$(wildcard $(top)/$(FIRMWARE_LOCATE)/PspTrustlets*_prod_$(FIRMWARE_TYPE).cbin) - -###13 -TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/TrustletKey_prod_$(FIRMWARE_TYPE).sbin -endif - -###18- Check for SMU firmware2 named either *.sbin or *.csbin -### TODO: Remove *.sbin section after the blobs repo is updated. -SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE).csbin -SMUFIRMWARE2_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE)_FN.csbin -ifeq ("$(wildcard $(SMUFIRMWARE2_FILE))","") -SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE).sbin -SMUFIRMWARE2_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE)_FN.sbin -endif - -ifeq ("$(wildcard $(SMUFWM_FN_FILE))","") -SMUFWM_FN_FILE= -SMUFIRMWARE2_FN_FILE= -endif - -add_opt_prefix=$(if $(call strip_quotes, $(1)), $(2) $(call strip_quotes, $(1)), ) - -OPT_STONEYRIDGE_XHCI_FWM_FILE=$(call add_opt_prefix, $(CONFIG_STONEYRIDGE_XHCI_FWM_FILE), --xhci) -OPT_STONEYRIDGE_GEC_FWM_FILE=$(call add_opt_prefix, $(CONFIG_STONEYRIDGE_GEC_FWM_FILEddd), --gec) - -OPT_AMD_PUBKEY_FILE=$(call add_opt_prefix, $(CONFIG_AMD_PUBKEY_FILE), --pubkey) -OPT_PSPBTLDR_FILE=$(call add_opt_prefix, $(PSPBTLDR_FILE), --bootloader) -OPT_SMUFWM_FILE=$(call add_opt_prefix, $(SMUFWM_FILE), --smufirmware) -OPT_PSPRCVR_FILE=$(call add_opt_prefix, $(PSPRCVR_FILE), --recovery) -OPT_PUBSIGNEDKEY_FILE=$(call add_opt_prefix, $(PUBSIGNEDKEY_FILE), --rtmpubkey) -OPT_PSPNVRAM_FILE=$(call add_opt_prefix, $(PSPNVRAM_FILE), --nvram) -OPT_PSPSECUREDEBUG_FILE=$(call add_opt_prefix, $(PSPSECUREDEBUG_FILE), --securedebug) -ifeq ($(CONFIG_USE_PSPSECUREOS),y) -OPT_PSPSCUREOS_FILE=$(call add_opt_prefix, $(PSPSCUREOS_FILE), --secureos) -OPT_PSPTRUSTLETS_FILE=$(call add_opt_prefix, $(PSPTRUSTLETS_FILE), --trustlets) -OPT_TRUSTLETKEY_FILE=$(call add_opt_prefix, $(TRUSTLETKEY_FILE), --trustletkey) -endif -OPT_SMUFIRMWARE2_FILE=$(call add_opt_prefix, $(SMUFIRMWARE2_FILE), --smufirmware2) -OPT_SMUSCS_FILE=$(call add_opt_prefix, $(SMUSCS_FILE), --smuscs) -SUBPROG_FN_SMU_FW=1 -OPT_SMUFWM_FN_FILE=$(call add_opt_prefix, $(SMUFWM_FN_FILE), --subprogram $(SUBPROG_FN_SMU_FW) --smufirmware) -OPT_SMUFIRMWARE2_FN_FILE=$(call add_opt_prefix, $(SMUFIRMWARE2_FN_FILE), --subprogram $(SUBPROG_FN_SMU_FW) --smufirmware2) - ifeq ($(FIRMWARE_TYPE),ST) OPT_COMBOCAPABLE=--combo-capable endif
+ifeq ($(CONFIG_USE_PSPSECUREOS),y) +PSP_USE_PSPSECUREOS="--use-pspsecureos" +endif + +OPT_PSP_USE_PSPSECUREOS=$(call strip_quotes, $(PSP_USE_PSPSECUREOS)) + $(obj)/amdfw.rom: $(call strip_quotes, $(CONFIG_STONEYRIDGE_XHCI_FWM_FILE)) \ $(call strip_quotes, $(CONFIG_STONEYRIDGE_GEC_FWM_FILE)) \ $(call strip_quotes, $(CONFIG_AMD_PUBKEY_FILE)) \ - $(call strip_quotes, $(PUBSIGNEDKEY_FILE)) \ - $(call strip_quotes, $(PSPBTLDR_FILE)) \ - $(call strip_quotes, $(PSPRCVR_FILE)) \ - $(call strip_quotes, $(PSPSCUREOS_FILE)) \ - $(call strip_quotes, $(PSPNVRAM_FILE)) \ - $(call strip_quotes, $(SMUFWM_FILE)) \ - $(call strip_quotes, $(SMUFWM_FN_FILE)) \ - $(call strip_quotes, $(SMUSCS_FILE)) \ - $(call strip_quotes, $(PSPSECUREDEBUG_FILE)) \ - $(call strip_quotes, $(PSPTRUSTLETS_FILE)) \ - $(call strip_quotes, $(TRUSTLETKEY_FILE)) \ - $(call strip_quotes, $(SMUFIRMWARE2_FILE)) \ - $(call strip_quotes, $(SMUFIRMWARE2_FN_FILE)) \ $(AMDFWTOOL) rm -f $@ @printf " AMDFWTOOL $(subst $(obj)/,,$(@))\n" $(AMDFWTOOL) \ $(OPT_STONEYRIDGE_XHCI_FWM_FILE) \ $(OPT_STONEYRIDGE_GEC_FWM_FILE) \ - $(OPT_AMD_PUBKEY_FILE) \ - $(OPT_PSPBTLDR_FILE) \ - $(OPT_SMUFWM_FILE) \ - $(OPT_PSPRCVR_FILE) \ - $(OPT_PUBSIGNEDKEY_FILE) \ - $(OPT_PSPSCUREOS_FILE) \ - $(OPT_PSPNVRAM_FILE) \ - $(OPT_PSPSECUREDEBUG_FILE) \ - $(OPT_PSPTRUSTLETS_FILE) \ - $(OPT_TRUSTLETKEY_FILE) \ - $(OPT_SMUFIRMWARE2_FILE) \ - $(OPT_SMUSCS_FILE) \ - $(OPT_AMD_PUBKEY_FILE) \ - $(OPT_PSPBTLDR_FILE) \ - $(OPT_SMUFWM_FILE) \ - $(OPT_SMUFWM_FN_FILE) \ - $(OPT_PSPRCVR_FILE) \ - $(OPT_PUBSIGNEDKEY_FILE) \ - $(OPT_PSPSCUREOS_FILE) \ - $(OPT_PSPNVRAM_FILE) \ - $(OPT_PSPSECUREDEBUG_FILE) \ - $(OPT_PSPTRUSTLETS_FILE) \ - $(OPT_TRUSTLETKEY_FILE) \ - $(OPT_SMUFIRMWARE2_FILE) \ - $(OPT_SMUFIRMWARE2_FN_FILE) \ - $(OPT_SMUSCS_FILE) \ $(OPT_COMBOCAPABLE)\ + $(OPT_PSP_USE_PSPSECUREOS) \ + --config $(FIRMWARE_LOCATE)/fw.cfg \ --flashsize $(CONFIG_ROM_SIZE) \ --location $(shell printf "0x%x" $(STONEYRIDGE_FWM_POSITION)) \ --output $@ @@ -270,7 +178,7 @@
else # ifeq ($(CONFIG_AMDFW_OUTSIDE_CBFS),y)
-#cbfs-files-y += apu/amdfw +cbfs-files-y += apu/amdfw apu/amdfw-file := $(obj)/amdfw.rom apu/amdfw-position := $(STONEYRIDGE_FWM_POSITION) apu/amdfw-type := raw
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#7).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 77 insertions(+), 113 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/7
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#8).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 77 insertions(+), 113 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/8
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#9).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 77 insertions(+), 113 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/9
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45287/9/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/45287/9/src/soc/amd/stoneyridge/Kco... PS9, Line 205: #config AMD_PUBKEY_FILE please remove those lines instead of commenting them out
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#12).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 70 insertions(+), 113 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/12
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45287/9/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/45287/9/src/soc/amd/stoneyridge/Kco... PS9, Line 205: #config AMD_PUBKEY_FILE
please remove those lines instead of commenting them out
Done. Removed.
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#19).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 71 insertions(+), 114 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/19
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#20).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 71 insertions(+), 114 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/20
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... File src/soc/amd/stoneyridge/fw_cz.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... PS22, Line 3: #XHCI_FWM_FILE xhci.bin It might be useful to call this TODO out in the commit message as remaining as a command line option or if there is a plan to allow it to be specified as either config or command line in the future.
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... File src/soc/amd/stoneyridge/fw_st.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... PS22, Line 4: #XHCI_FWM_FILE xhci.bin Same, it would be useful to understand why this is included but commented out in the cfg.
Hello Jason Glenesk, build bot (Jenkins), Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#23).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 71 insertions(+), 114 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/23
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#27).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 74 insertions(+), 114 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/27
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
Patch Set 27:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... File src/soc/amd/stoneyridge/fw_cz.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... PS22, Line 3: #XHCI_FWM_FILE xhci.bin
It might be useful to call this TODO out in the commit message as remaining as a command line option […]
Done
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... File src/soc/amd/stoneyridge/fw_st.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... PS22, Line 4: #XHCI_FWM_FILE xhci.bin
Same, it would be useful to understand why this is included but commented out in the cfg.
Done. Removed.
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Dave Frodin, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45287
to look at the new patch set (#31).
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
amdfwtool: Apply the change of config file to stoneyridge
Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc A src/soc/amd/stoneyridge/fw_cz.cfg A src/soc/amd/stoneyridge/fw_st.cfg 4 files changed, 74 insertions(+), 114 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45287/31
Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
Abandoned
squashed.
-
Bao Zheng (Code Review) -
Felix Held (Code Review)
-
Jason Glenesk (Code Review)