Change in coreboot[master]: ec/google/chromeec: Provide EC access for Retimer firmware update - coreboot-gerrit

20 Jan 2021


      Attention is currently required from: John Zhao, Tim Wawrzynczak, Brandon Breitenstein, Rajmohan Mani.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49257 )
Change subject: ec/google/chromeec: Provide EC access for Retimer firmware update
......................................................................
Patch Set 5:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/49257/comment/a82d4333_1394ff1c 
PS4, Line 242: \_SB_.PCI0.LPCB.EC0_.
...
oh that's right, there is no struct/device in the hierarchy right now which will resolve to an ACPI  […]
Ah well, sorry for the diversion.  I'll add cleaning up the EC ACPI path to the endless todo list..
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49257
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3817d93cfdeedf15825dab6c537b151fd063338b
Gerrit-Change-Number: 49257
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein brandon.breitenstein@intel.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Rajmohan Mani rajmohan.mani@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: John Zhao john.zhao@intel.corp-partner.google.com
Gerrit-Attention: John Zhao john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: John Zhao john.zhao@intel.com
Gerrit-Attention: Brandon Breitenstein brandon.breitenstein@intel.com
Gerrit-Attention: Rajmohan Mani rajmohan.mani@intel.com
Gerrit-Comment-Date: Wed, 20 Jan 2021 03:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao john.zhao@intel.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: John Zhao john.zhao@intel.com
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Gerrit-MessageType: comment