Attention is currently required from: Daniel Peng, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/84925?usp=email )
Change subject: mb/google/nissa/var/glassway: Add initial LTE related settings
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84925/comment/f1fc8a8c_1a059b7d?usp... :
PS2, Line 12: 4. Add I2C SX9324(P-sensor) support.
I just know that both SX9324 and LTE setting have relationship. […]
Thank you for your quick reply.
I do not have the schematics, so I do not know. If they are related, then keeping it in one commit is fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84925?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida56ff338d82f48aef419a65830a3380c83123d5
Gerrit-Change-Number: 84925
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 12:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com