[M] Change in coreboot[main]: mb/google/brox: Fix booting to kernel without battery

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Jayvik Desai, Kapil Porwal, Keith Short, Krishna P Bhat D, Nick Vaccaro, Rishika Raj, Ronak Kanabar, Shelley Chen, Sowmya Aralguppe, Sowmya Aralguppe.

Karthik Ramasubramanian has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83752?usp=email )

Change subject: mb/google/brox: Fix booting to kernel without battery
......................................................................

Patch Set 15:

(8 comments)

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/4d472271_bbaca9e4?usp... :
PS11, Line 15: #define SET_PSYSPL2(e, w) ((e) * (w) / 100)
> We only have lotso board - I can test it there  […]

Acknowledged. Let us update Brox for now. Once all the variant usages are removed, we can remove it.

https://review.coreboot.org/c/coreboot/+/83752/comment/6bfd346a_dd95a4d3?usp... :
PS11, Line 16: SET_PL2
> Other variant's build were failing - just to make sure other variants are not affected i added this  […]

Acknowledged. Let us update Brox for now. Once all the variant usages are removed, we can remove it.

https://review.coreboot.org/c/coreboot/+/83752/comment/a7ce42ad_893844e8?usp... :
PS11, Line 146: void variant_update_psys_power_limits
> Other variant's build were failing - just to make sure other variants are not affected i added this  […]

Acknowledged

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/e517df42_1fd43d9e?usp... :
PS15, Line 64: 35
I think with 32% efficiency it is 35 W. But for charger rating >= 60 W, the code is using 36% efficiency (39 Watts). Do you want it to be 32% efficiency or 36% efficiency?

https://review.coreboot.org/c/coreboot/+/83752/comment/43228663_d31ad1d4?usp... :
PS15, Line 67: 
Nit: Remove this extra line.

https://review.coreboot.org/c/coreboot/+/83752/comment/ba46c483_2b042ede?usp... :
PS15, Line 90: CONFIG(EC_GOOGLE_CHROMEEC)
This will be true for all the Google Mainboard even in fatcat (@subrata to confirm) and hence can be removed.

https://review.coreboot.org/c/coreboot/+/83752/comment/a2ad9e79_6cf76430?usp... :
PS15, Line 106: Adapter is not connected
Power limit not updated because USB Type-C charger is not detected.

File src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h:

https://review.coreboot.org/c/coreboot/+/83752/comment/fc51cb35_ac8a2238?usp... :
PS15, Line 11: #define FSPM_MAX_NONTURBO_FREQ	0x1
Please define this in src/soc/intel/alderlake/chip.h. This belongs there. Also define all the values that this UPD can take as an enum.