[XS] Change in libgfxinit[main]: transcoder: Don't try to disable disabled DDI func - coreboot-gerrit

22 Jul 2024


      Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83598?usp=email )
Change subject: transcoder: Don't try to disable disabled DDI func
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File common/hw-gfx-gma-transcoder.adb:
https://review.coreboot.org/c/libgfxinit/+/83598/comment/9a3b21f1_112171bb?u... :
PS1, Line 376:          Registers.Is_Set_Mask (Trans.DDI_FUNC_CTL, DDI_FUNC_CTL_ENABLE, Enabled);
(to `Registers.Is_Set_Mask`) WHY are you not a function??? /s
I guess it's because it has side-effects
-- 
To view, visit https://review.coreboot.org/c/libgfxinit/+/83598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Ia505422570d967b192fe2eb8cab10f305aff3dd7
Gerrit-Change-Number: 83598
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:27:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes