Change in coreboot[master]: mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37569 )
Change subject: mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC ......................................................................
mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC
Change-Id: I934830c09f7996e8f5aae5d5abe9fb6014fb478d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/am1i-a/romstage.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/37569/1
diff --git a/src/mainboard/asus/am1i-a/romstage.c b/src/mainboard/asus/am1i-a/romstage.c index 5e1218a..c0f5c04 100644 --- a/src/mainboard/asus/am1i-a/romstage.c +++ b/src/mainboard/asus/am1i-a/romstage.c @@ -24,8 +24,6 @@ #include <superio/ite/common/ite.h> #include <superio/ite/it8623e/it8623e.h>
-#define ITE_CONFIG_REG_CC 0x02 - #if CONFIG_UART_FOR_CONSOLE == 0 #define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1) #elif CONFIG_UART_FOR_CONSOLE == 1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37569 )
Change subject: mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC ......................................................................
Patch Set 1: Code-Review+1
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37569 )
Change subject: mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC ......................................................................
Patch Set 1: Code-Review+2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37569 )
Change subject: mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC ......................................................................
Patch Set 1:
Just tested this change, it builds OK and seems to be working fine.
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37569 )
Change subject: mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC ......................................................................
mb/asus/am1i-a: Remove defined and not used ITE_CONFIG_REG_CC
Change-Id: I934830c09f7996e8f5aae5d5abe9fb6014fb478d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37569 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Mike Banon mikebdp2@gmail.com --- M src/mainboard/asus/am1i-a/romstage.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Mike Banon: Looks good to me, approved
diff --git a/src/mainboard/asus/am1i-a/romstage.c b/src/mainboard/asus/am1i-a/romstage.c index 5e1218a..c0f5c04 100644 --- a/src/mainboard/asus/am1i-a/romstage.c +++ b/src/mainboard/asus/am1i-a/romstage.c @@ -24,8 +24,6 @@ #include <superio/ite/common/ite.h> #include <superio/ite/it8623e/it8623e.h>
-#define ITE_CONFIG_REG_CC 0x02 - #if CONFIG_UART_FOR_CONSOLE == 0 #define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1) #elif CONFIG_UART_FOR_CONSOLE == 1
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)
-
Mike Banon (Code Review)
-
Paul Menzel (Code Review)