[S] Change in coreboot[main]: ec/google/chromeec: Drop 'choice' selections for EC and PD firmware - coreboot-gerrit

25 Jul 2024


      Attention is currently required from: Caveh Jalali, Felix Singer, Forest Mittelberg, Julius Werner, Martin L Roth.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83639?usp=email )
Change subject: ec/google/chromeec: Drop 'choice' selections for EC and PD firmware
......................................................................
Patch Set 3:
(1 comment)
File src/ec/google/chromeec/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83639/comment/eb179bb3_00083fd3?usp... :
PS2, Line 73: CONFIG_EC_GOOGLE_CHROMEEC_FIRMWARE_FILE := $(call strip_quotes,$(CONFIG_EC_GOOGLE_CHROMEEC_FIRMWARE_FILE))
...
This line is still needed.
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie37ff3a188b414fd099fbb344858bca4df419086
Gerrit-Change-Number: 83639
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Thu, 25 Jul 2024 02:21:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de