Change in coreboot[master]: sb/intel/i82801ix/smihandler.c: Comment out dead increment - coreboot-gerrit

25 Apr 2022


      Attention is currently required from: Arthur Heymans, Patrick Rudolph, Elyes Haouas.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62541 )
Change subject: sb/intel/i82801ix/smihandler.c: Comment out dead increment
......................................................................
Patch Set 2:
(1 comment)
File src/southbridge/intel/i82801ix/smihandler.c:
https://review.coreboot.org/c/coreboot/+/62541/comment/d4447b41_2a06179a 
PS2, Line 65: // data &= mask;
            : 			// if (smi1)
            : 			// 	southbridge_smi_command(data);
            : 			// return;
Could we just remove all the commented out code instead?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62541
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifef67fc6415af1260d1a1df54f53fbe67f8860bb
Gerrit-Change-Number: 62541
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth martinroth@google.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 24 Apr 2022 21:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment