Attention is currently required from: Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74609 )
Change subject: mb/google/skyrim: Add mainboard chip.h
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/skyrim/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74609/comment/5aac48fa_d63ef86d
PS8, Line 109: mainboard_ops
Hrmm, if you just add a chip.h as a sibling does it work? […]
I think sconfig expects you to introduce chip driver for it include the header.
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74609/comment/f31865a1_13168ca7
PS8, Line 2: chip mainboard/google/skyrim/variants/baseboard
If you are concerned about updating all the mainboards with devicetree. […]
I have sent an RFC CL to introduce a include keyword in devicetree grammar - CB: 74736
That allows you to include header file in the devicetree such that it gets included in the parseed devicetree file. With that, I think we should be able to refer to netnames in the devicetree.
Please share your thoughts and also use it if it helps with the effort here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74609
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f
Gerrit-Change-Number: 74609
Gerrit-PatchSet: 8
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 20:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment