Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44456 )
Change subject: amd/picasso/psp_verstage: add vboot rsa function
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44456/8/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/44456/8/src/soc/amd/picasso/psp_ver...
PS8, Line 112: int
Can `size_t` or `unsigned int` be used? It looks like, the vboot function signature does not allow that. :/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44456
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c1d13092db5a84191642444f3df9c26925e475
Gerrit-Change-Number: 44456
Gerrit-PatchSet: 8
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Aug 2020 12:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment