Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Xiwen Shao, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )
Change subject: soc/mediatek/mt8196: Add tracker driver ......................................................................
Patch Set 14:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84929/comment/09e15bb6_58fb8ed0?usp... : PS12, Line 10: hen bus
move to previous line
Done
https://review.coreboot.org/c/coreboot/+/84929/comment/2dc31d4b_2f3b6356?usp... : PS12, Line 13: build
Build
Done
https://review.coreboot.org/c/coreboot/+/84929/comment/53ad7057_04aba77f?usp... : PS12, Line 13: hw
HW or hwardware
Done
https://review.coreboot.org/c/coreboot/+/84929/comment/461b1a20_3782e586?usp... : PS12, Line 14: causes the platform to restart
triggers a reset to the platform,
Done
https://review.coreboot.org/c/coreboot/+/84929/comment/4a29fa01_e8fbdc6d?usp... : PS12, Line 19: has a bus timeout.
move to previous line.
Done
File src/soc/mediatek/mt8196/include/soc/tracker.h:
https://review.coreboot.org/c/coreboot/+/84929/comment/06da4bf9_88ff0fbb?usp... : PS14, Line 19: Remove extra blank line.
File src/soc/mediatek/mt8196/tracker.c:
https://review.coreboot.org/c/coreboot/+/84929/comment/3337d2ed_86a4aaa8?usp... : PS14, Line 27: AW_TRACK_L_OFFSET, AW_TRACK_H_OFFSET Adding a trailing `,`