Attention is currently required from: Karthik Ramasubramanian, Shelley Chen, Sumeet R.P..
Subrata Banik has posted comments on this change by Sumeet R.P.. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email )
Change subject: mb/google/brox/variants/brox: remove PL4 value modification
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83662/comment/6503c3c3_b9c09ed5?usp... :
PS1, Line 8:
: Remove PL4 value modification based on PsysPL3 valuei.
:
the motivation not clear? can you please give a reason why it existed before and why you are not removing this code ?
trying to understand if this code ever intended to solve any problem ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83662?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic7fbc6386769aa9f76a8665a742c97dfd790fd1d
Gerrit-Change-Number: 83662
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R.P.
sumeet4linux@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Sumeet R.P.
sumeet4linux@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 01 Sep 2024 17:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No