[XL] Change in coreboot[master]: device/pnp,util/sconfig: introduce and use `REG8` resource type - coreboot-gerrit

6 Feb 2023


      Attention is currently required from: Felix Singer, Nico Huber, Patrick Georgi, Martin L Roth, Damien Zammit, Tristan Corrick, Paul Menzel, Angel Pons, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 )
Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type
......................................................................
Patch Set 8:
(1 comment)
This change is ready for review.
File src/include/device/resource.h:
https://review.coreboot.org/c/coreboot/+/48925/comment/8aadfc1a_9cebc049 
PS8, Line 18: #define IORESOURCE_PREFETCH	0x00001000	/* No side effects */
...
oof, good catch!
Any idea if 0x00200000 would work? Were 0x00200000-0x00800000 left out on purpose?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36679148cbfdbd1e38b3c4ce092562769f9806ab
Gerrit-Change-Number: 48925
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Tristan Corrick tristan@corrick.kiwi
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 06 Feb 2023 23:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment