Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34402 )
Change subject: mainboard/facebook/fbg1701: Enable display of logo ......................................................................
mainboard/facebook/fbg1701: Enable display of logo
Specify FSP1_1_LOGO_FILE_NAME and enable display of logo.
BUG=N/A TEST=Display is displayed on Facebook FBG1701
Change-Id: I24c6fcd829aa45c1b194f6ae273a20526aa89943 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34402/1
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 95d8f6c..ada5f2a 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -76,7 +76,13 @@
config FSP1_1_DISPLAY_LOGO bool - default n + default y + +config FSP1_1_LOGO_FILE_NAME + string + depends on FSP1_1_DISPLAY_LOGO + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/logo.bmp" +
config SPI_FLASH_INCLUDE_ALL_DRIVERS bool
Hello Patrick Rudolph, Lance Zhao, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34402
to look at the new patch set (#3).
Change subject: mab/facebook/fbg1701: Enable display of logo ......................................................................
mab/facebook/fbg1701: Enable display of logo
Specify FSP1_1_LOGO_FILE_NAME and enable display of logo.
BUG=N/A TEST=Display is displayed on Facebook FBG1701
Change-Id: I24c6fcd829aa45c1b194f6ae273a20526aa89943 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34402/3
Hello Patrick Rudolph, Lance Zhao, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34402
to look at the new patch set (#4).
Change subject: mb/facebook/fbg1701: Enable display of logo ......................................................................
mb/facebook/fbg1701: Enable display of logo
Specify FSP1_1_LOGO_FILE_NAME and enable display of logo.
BUG=N/A TEST=Display is displayed on Facebook FBG1701
Change-Id: I24c6fcd829aa45c1b194f6ae273a20526aa89943 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34402/4
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34402 )
Change subject: mb/facebook/fbg1701: Enable display of logo ......................................................................
Patch Set 4: Code-Review+2
Frans Hendriks has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34402 )
Change subject: mb/facebook/fbg1701: Enable display of logo ......................................................................
Abandoned
Decided not including the customer logo
-
Frans Hendriks (Code Review) -
Lance Zhao (Code Review)