Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Uploaded patch set 7 to modify the error msg I used in Makefile.mk: "cannot" -> "should not". The reason is that "cannot" is a strong word and could mislead people into believing that it's impossible to workaround BUILD_TIMELESS_WITH_GITREV. However, its not since anyone could simply cheat BUILD_TIMELESS_WITH_GITREV by pushing their local changes to some other remote. With patch set 7, I hope that people who encounter this error, understand the motivation behind BUILD_TIMELESS_WITH_GITREV.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 7
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 21 Apr 2024 13:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment