Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 3:
(9 comments)
File src/soc/mediatek/mt8186/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/cf456489_2aed11e1 PS3, Line 68: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/e3bcf115_865c98a7 PS3, Line 73: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/217087fb_e593b3ea PS3, Line 81: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/f0f391e5_d97b11cc PS3, Line 95: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/eddebbe7_f725b7c9 PS3, Line 96: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/ca65357a_ceb2b628 PS3, Line 97: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/c926d979_e0c7e63d PS3, Line 98: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/f98fbd31_18d2b6bb PS3, Line 99: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136077): https://review.coreboot.org/c/coreboot/+/60317/comment/fc643189_5cc55a32 PS3, Line 101: #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)