Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58064 )
Change subject: soc/intel/common/../cse: Helper function to check CSE device `devfn` status
......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/58064/comment/22b99760_1a1490de
PS2, Line 584: pci_devfn_t
`unsigned int`
Ack
https://review.coreboot.org/c/coreboot/+/58064/comment/cf05711f_737dc2b6
PS2, Line 584: enabled
suggestion: `enabled` typically means the `struct device *dev` is enabled... […]
Ack
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/58064/comment/f12ca6ef_76165bb0
PS2, Line 156: pci_devfn_t
`unsigned int`
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I208b07e89e3aa9d682837380809fbff01ea225b0
Gerrit-Change-Number: 58064
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 08:46:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment