Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/25663 )
Change subject: device/dram/ddr3: improve XMP support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c
File src/device/dram/ddr3.c:
https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c@584
PS2, Line 584: print_ns(" tCMDmin : ", dimm->tCMD);
Should I add a function along the lines of print_tck for this?
printk(BIOS_INFO, ... should be sufficient
--
To view, visit
https://review.coreboot.org/25663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4f545ed1df92c146be02f56fea0ca9037478649
Gerrit-Change-Number: 25663
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Elkouby
streetwalkermc@gmail.com
Gerrit-Reviewer: Dan Elkouby
streetwalkermc@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 14 Apr 2018 11:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No