[XS] Change in coreboot[main]: commonlib/loglevel.h: Fix Wunterminated-string-initialization error - coreboot-gerrit

18 Sep 2024


      Attention is currently required from: Elyes Haouas.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84171?usp=email )
Change subject: commonlib/loglevel.h: Fix Wunterminated-string-initialization error
......................................................................
Patch Set 4: Code-Review-2
(1 comment)
File src/commonlib/include/commonlib/loglevel.h:
https://review.coreboot.org/c/coreboot/+/84171/comment/deefd224_9a94b214?usp... :
PS4, Line 169: 	/* Note: These strings are *not* null-terminated to save space. */
This comment is here explaining why things are the way they are specifically to make sure nobody uploads a patch like this. Please read before you delete.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84171?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b149239cf301aa00b2c1ee8ff811492590a07f9
Gerrit-Change-Number: 84171
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 17 Sep 2024 23:25:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes