Attention is currently required from: Kapil Porwal, Pratikkumar V Prajapati, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74770?usp=email )
Change subject: mainboard/google/rex: Enable crashlog
......................................................................
Patch Set 18:
(4 comments)
Patchset:
PS18:
wondering why these CLs are not build test atleast ?
PS18:
if not, just ignore this
Acknowledged
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74770/comment/a694446c_eaef408b :
PS18, Line 838: device shared_sram2 on end
device ref shared_sram2 on end <--- move this line at 352
https://review.coreboot.org/c/coreboot/+/74770/comment/fae8ba08_a14174a8 :
PS18, Line 839: device shared_sram on end
device ref shared_sram on end <--- move this line at 415
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74770?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d3a9fb41d1293f021ad9de9b29c756cb7559373
Gerrit-Change-Number: 74770
Gerrit-PatchSet: 18
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 06:31:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment