Attention is currently required from: Shelley Chen, Furquan Shaikh, Arthur Heymans, Prasad Malisetty. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 )
Change subject: libpayload: Add support for PCI MMIO CONFIG access. ......................................................................
Patch Set 40:
(8 comments)
File payloads/libpayload/drivers/pci_io_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/e0bfcc30_bc22ef85 PS29, Line 70: pcidev_t *dev)
This is still not fixed.
Done
File payloads/libpayload/drivers/pci_mmio_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/202835b7_facf0a37 PS29, Line 2: Copyright
nit: missing space before Copyright
Done
https://review.coreboot.org/c/coreboot/+/57615/comment/dec22c57_f67a2bdd PS29, Line 4: Redistribution
nit: missing space before Redistribution.
Done
https://review.coreboot.org/c/coreboot/+/57615/comment/c43eca8b_b00ecfb4 PS29, Line 26: /
nit: missing space at the beginning of this line.
Done
https://review.coreboot.org/c/coreboot/+/57615/comment/e6a6effc_067b4e79 PS29, Line 74: pcidev_t *dev)
still an issue.
Done
File payloads/libpayload/drivers/qc_pci_mmio_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/ec8f839e_9deecbb2 PS37, Line 107: cfg_address = (void*) pci_mmio_info->config_base;
"(void*)" should be "(void *)" […]
Done
File payloads/libpayload/include/qc_pci.h:
https://review.coreboot.org/c/coreboot/+/57615/comment/b9d36c75_e89e57cb PS37, Line 70: #endif
trailing whitespace […]
Done
File payloads/libpayload/include/qc_pci.h:
https://review.coreboot.org/c/coreboot/+/57615/comment/ed41be0e_81356d83 PS29, Line 70: #endif
trailing whitespace […]
Done
-
Ravi Kumar Bokka (Code Review)